[Bug 727825] omxvideodec: Enhance colorformat support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727825
  GStreamer | gst-omx | git

--- Comment #5 from Aurélien Zanelli <aurelien.zanelli at parrot.com> 2014-04-09 08:01:47 UTC ---
(In reply to comment #1)
> Hi, I do not see anything wrong but it's hard to check everything :)  I can at
> least test it on RPI by the end of the week if no body can do it before.
> 
> I also wonder if you could split the commit this way: 1 commit that add the
> helper and 1 commit per place where you use it.
> Also it seems you did some refactoring, would be nice to put them in separate
> commits.
> 
> Because it could help for git bisect later.
I can if you prefer, I just did a single patch to ease attachment.

> Your decoder can output all those formats ? On RPI it can only output I420 or
> NV12. But there is an other component "resize" that can do colorspace
> conversion and scaling. 
The video decoder, no, but it have a post-processor which can do color
conversion.

> About OMX_COLOR_Format32bitARGB8888, on RPI I had to do this
> http://cgit.collabora.com/git/user/julien/gst-omx.git/commit/?h=resize&id=68ce07b32b285bccca82b19fde31b3646ac225a5
> but we do not use this path anyway :)
I agree with Sebastian, OMX_COLOR_Format32bitARGB8888 to GST_VIDEO_FORMAT_BGRx
should be RPi specific.
Also, as I mentionned in code comments, there is a little pitfall about
OMX_COLOR_Format32bitARGB8888 and OMX_COLOR_Format32bitBGRA8888 : name don't
match description. I prefer to follow description

> Out of curiosity, do you have support for OMX_UseEGLImage on your platform ?
No, I haven't.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.