[Bug 727878] qtdemux: remove duplicated code when parsing trex atom

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Apr 9 01:15:21 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=727878
  GStreamer | gst-plugins-good | 1.x

--- Comment #3 from Jimmy <yongjin.ohn at lge.com> 2014-04-09 08:15:14 UTC ---
OK I see.
how about change to following patch?
I thinks that it's better for code readability.


(In reply to comment #2)
> (From update of attachment 273854 [details])
> See the comment above the first one. It reads the sample description index,
> then the second one reads the duration into the same variable and overwrites
> it.
> 
> Maybe change the first one to write to a dummy variable that is not used
> elsewhere... for clarity. But the code is correct

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list