[Bug 727886] GstVideoGLTextureUploadMeta assumes no color conversion is done during upload

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727886
  GStreamer | gst-plugins-base | git

--- Comment #13 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-04-10 14:56:08 UTC ---
(In reply to comment #11)
> Yes, adding extra API to the meta sounds like a good option. However, I would
> retrieve a GstVideoInfo instead, since it can contain additional information
> like plane offsets and stride. But why set_caps() ? When would I want to use
> it? I would only add something like get_gl_video_info() .

VideoInfo stride/offset/size is for mappable memory. When using the upload
meta, you should not need that information, since the actual upload (often not
really an upload) is done by the buffer owner/producer.

The suggestion for the get_caps()/set_caps() is to handle the case where there
is multiple format to which you can upload (think ARGB, BGRA, RGBA, RGB565,
etc.). Though, if using the extra params in the allocation query, I'd say just
add a GstVideoFormat, full caps would be overkill. The params would have a set
of GstVideoFormat to choose from, if not provided, it would mean the only valid
format is the one in the negotiated caps.

But I think to go further it would be easier if someone provide some code that
show the proposed API changes.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.