[Bug 728805] New: tsdemux: always conciders mpeg audio ADTS as mpegversion=2

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=728805
  GStreamer | gst-plugins-bad | 1.x

           Summary: tsdemux: always conciders mpeg audio ADTS as
                    mpegversion=2
    Classification: Platform
           Product: GStreamer
           Version: 1.x
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: tsaunier at gnome.org
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


According to tsdemux code, mpeg audio with stream-format=adts will always have
mpegversion=2, but aacparse says it can also be mpegversion=4.

For example, on that file:
https://dl.dropboxusercontent.com/u/2804070/tron_en_ge_aac_h264.ts tsdemux
conciders the stream as being mpegversion=2 but aacparse will change that to
being mpegversion=4.

It will not cause much issue in practice but running gst-discoverer on that
sample will tell us that the file contains 4 audio tracks 2 with
mpegtsversion=2 and 2 other with 4 which is clearly wrong.

I am attaching a patch where we just do not set the version at the demuxer
level and let the parser do it, I am not sure it is really correct but as
parser are now mandatory it works.

Otherwize we should just parse further in the demuxer to get that info.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.