[Bug 729067] goom filter: left shift of 24 places cannot be represented in type 'int'

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Apr 27 15:17:04 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=729067
  GStreamer | gst-plugins-good | git

--- Comment #5 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-04-27 22:16:58 UTC ---
The runtime error bit is still confusing, since it's caused by the special
'-fsanitize' option which you don't mention there. IMHO just say that you're
fixing undefined behaviour, like "don't left-shift into the sign bit, the
result is undefined" or somesuch.

I would stick to the minimal patch required to fix this, unless you actually
understand how the code affected by your changes works, or you're sure it
doesn't have undesired side-effects (or it generates further warnings).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


More information about the gstreamer-bugs mailing list