[Bug 729088] Catch XWindows errors when destroying xwindow

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=729088
  GStreamer | gst-plugins-base | git

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.dufresne at collabora.
                   |                            |co.uk

--- Comment #5 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-04-29 13:44:59 UTC ---
(In reply to comment #3)
> (In reply to comment #1)
> > Why do you switch the Warning to an Error?
> > 
> > -    GST_WARNING_OBJECT (xvimagesink, "could not output image - no window");
> > +    GST_ERROR_OBJECT (xvimagesink, "could not output image - no window");
> 
> Because it will return a FLOW_ERROR as well. It seemed odd to me that it would
> be a warning if it resulted in an error after all. With this change, it behaves
> more like the 'activate_failed' label.

if it's an unrecoverable error, most likely you want the pipeline to stop. Then
you should communicate this error to the application by using
GST_ELEMENT_ERROR(). If it's recoverable, it's a warning.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.