[Bug 733916] Simple pipeline with textoverlay and fakesink fails to negotiate

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733916
  GStreamer | gst-plugins-base | 1.4.0

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #282934|none                        |reviewed
             status|                            |

--- Comment #11 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-08-11 07:29:32 UTC ---
Review of attachment 282934:
 --> (https://bugzilla.gnome.org/review?bug=733916&attachment=282934)

Make sense, now the same code is only required in all the other subtitle
overlay elements :)

::: ext/pango/gstbasetextoverlay.c
@@ +715,2 @@
   GstQuery *query;
+  gboolean attach = TRUE;

Shouldn't the default be FALSE?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.