[Bug 734412] multiqueue: The buffering logic can lead to a pipeline stuck in PAUSED forever

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=734412
  GStreamer | gstreamer (core) | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #283076|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-08-11 11:25:13 UTC ---
Review of attachment 283076:
 --> (https://bugzilla.gnome.org/review?bug=734412&attachment=283076)

::: plugins/elements/gstmultiqueue.c
@@ +924,3 @@
       mq->buffering = TRUE;
       mq->percent = percent;
       post = TRUE;

Does this make sense? You set multiqueue to buffering mode...

@@ +933,3 @@
+        post = FALSE;
+
+        break;

... but don't post a buffering message. Wouldn't it be clearer to just store
the maximum percentage all the time, and also only have mq->buffering==TRUE if
we actually posted a message that would trigger buffering?

It seems like this here only makes the code even harder to understand, even if
it probably does the right thing :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.