[Bug 735248] Support OpenSSL for AES decryption of HLS fragments.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735248
  GStreamer | gst-plugins-bad | git

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #284257|none                        |needs-work
             status|                            |

--- Comment #1 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2014-08-22 21:50:09 UTC ---
Review of attachment 284257:
 --> (https://bugzilla.gnome.org/review?bug=735248&attachment=284257)

::: ext/hls/gsthlsdemux.c
@@ +1684,3 @@
     last_sequence =
+        GST_M3U8_MEDIA_FILE (g_list_last (demux->client->current->files)->
+        data)->sequence;

Unrelated change

@@ +1786,3 @@
     if (GST_M3U8 (previous_variant->data)->iframe && new_bandwidth ==
+        GST_M3U8 (g_list_first (demux->client->main->iframe_lists)->
+            data)->bandwidth)

Unrelated change.

@@ +1854,3 @@
+{
+  int flen = 0;
+  int len = (int) length;

You may want to verify that length is < G_MAXINT.

@@ +1863,3 @@
+    return FALSE;
+  if (!EVP_DecryptFinal_ex (&demux->aes_ctx, decrypted_data + len, &flen))
+    return FALSE;

This shouldn't be required, as you've already checked that the length is a
multiple of the block size (16 bytes), so there should never be extra data.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.