[Bug 734908] [API] Add gstgralloc library

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=734908
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #283596|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-08-27 07:39:27 UTC ---
Review of attachment 283596:
 --> (https://bugzilla.gnome.org/review?bug=734908&attachment=283596)

::: gst-libs/gst/Makefile.am
@@ +17,2 @@
 SUBDIRS = interfaces basecamerabinsrc codecparsers \
+     insertbin uridownloader mpegts base video $(GL_DIR) $(WAYLAND_DIR)
$(GRALLOC_DIR)

Also it needs to be added to DIST_SUBDIRS

::: gst-libs/gst/gralloc/gstgralloc.c
@@ +97,3 @@
+
+GstAllocator *
+gst_gralloc_allocator_new (void)

Shouldn't the gralloc device (and module?) be a parameter of the constructor?

@@ +115,3 @@
+
+  alloc->mem_map = NULL;
+  alloc->mem_unmap = NULL;

map could be implemented with lock(), no?

@@ +117,3 @@
+  alloc->mem_unmap = NULL;
+  alloc->mem_copy = NULL;
+  alloc->mem_share = NULL;

There is no copy or sharing (via refcounting!) support in gralloc?

@@ +161,3 @@
+  GstVideoInfo info;
+
+  if (!GST_IS_GRALLOC_ALLOCATOR (allocator)) {

Should be a g_return_val_if_fail() as it's a programming error

::: gst-libs/gst/gralloc/gstgrallocbufferpool.c
@@ +39,3 @@
+gst_gralloc_buffer_pool_get_options (GstBufferPool * pool)
+{
+  static const gchar *options[] = { GST_BUFFER_POOL_OPTION_VIDEO_META, NULL

Why do you need the videometa at all for an opaque format?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.