[Bug 732533] gstomx omxvideoenc don't recover after aspect ratio change on RPI

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=732533
  GStreamer | gst-omx | 1.2.4

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #284643|none                        |needs-work
             status|                            |

--- Comment #17 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-08-28 07:49:30 UTC ---
Review of attachment 284643:
 --> (https://bugzilla.gnome.org/review?bug=732533&attachment=284643)

::: omx/gstomxvideoenc.c
@@ +931,3 @@
+  guint par_n;
+  guint par_d;
+} PAR;

Just use OMX_CONFIG_POINTTYPE here

@@ +933,3 @@
+} PAR;
+
+static PAR broadcom_supported_aspect_ratios[] = {

Make the table const

@@ +954,3 @@
+  par = &broadcom_supported_aspect_ratios[0];
+  best_par = par;
+  best_ar_diff =

Instead of choosing the closest value, just put the only allowed values in the
sinkpad template caps. You'll distort the frames if you choose a value
different from the actual one, no matter how close it is

@@ +1112,3 @@

+#ifdef USE_OMX_TARGET_RPI
+  // aspect ratio

No C99 comments

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.