[Bug 735564] gdkpixbufdec: Error when using gdkpixbufdec with ImageFreeze element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735564
  GStreamer | gst-plugins-good | unspecified

--- Comment #2 from Vineeth <vineeth.tm at samsung.com> 2014-08-28 08:30:56 UTC ---
Created an attachment (id=284664)
 View: https://bugzilla.gnome.org/attachment.cgi?id=284664
 Review: https://bugzilla.gnome.org/review?bug=735564&attachment=284664

New patch as per comments

Hi Sebastian,

Thanks for the review.
I have updated the patch along the lines of 1st method by adding EOS and
NOT_LINKED

And i have one question regarding ImageFreeze,
now i understood EOS is being passed because only the first buffer needs to be
shown,
then in that case, the below condition will never satisfy right? Should we have
this condition?

static GstFlowReturn
gst_image_freeze_sink_chain (GstPad * pad, GstObject * parent,
    GstBuffer * buffer)
{
...
  if (self->buffer) {
    GST_DEBUG_OBJECT (pad, "Already have a buffer, dropping");
    gst_buffer_unref (buffer);
    g_mutex_unlock (&self->lock);
    return GST_FLOW_EOS;
  }
...
...
}



Regards,
Vineeth

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.