[Bug 661726] [subparse] missing race condition protect with seek

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=661726
  GStreamer | gst-plugins-base | 0.10.x

Arnaud Vrac <rawoul> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rawoul at gmail.com

--- Comment #5 from Arnaud Vrac <rawoul at gmail.com> 2014-08-28 13:26:43 UTC ---
I still see this happening in 1.4:

seek to 0ms from start
subparse: <parser:src> Handling qos event
subparse: <parser:src> Handling seek event
subparse: <parser:sink> Handling flush-start event
subparse: <parser> flow: flushing
subparse: <parser:sink> Handling flush-stop event
subparse: <parser:sink> Handling custom-downstream-sticky event
streamsynchroni: <streamsynchronizer1:sink_2> Non-TIME segment: bytes
subparse: <parser:sink> Handling segment event
subparse: <parser> newsegment (time)
subparse: discontinuity
subparse: initialising parser
subparse: <parser> successfully converted 4096 characters from ISO-8859-15 to
UTF-8
subparse: <parser> need_segment=0
subparse: <parser> Parsing line '1'
subparse: <parser> Parsing line '00:00:12,821 --> 00:00:16,229'
subparse: parsing timestamp '00:00:12,821'
subparse: parsing timestamp '00:00:16,229'
subparse: <parser> Parsing line 'Nous avons trouvés ça dans les'
subparse: <parser> Parsing line 'affaires de Mlle Reed.'
subparse: <parser> Parsing line ''
subparse: <parser> Parsing line '2'
subparse: <parser> Parsing line '00:00:16,354 --> 00:00:18,263'
subparse: parsing timestamp '00:00:16,354'
subparse: parsing timestamp '00:00:18,263'
subparse: <parser> Parsing line 'C'est une carte d'accés pour l'ONU.'
subparse: <parser> Parsing line ''
subparse: <parser> Parsing line '3'
subparse: <parser> Parsing line '00:00:18,388 --> 00:00:20,730'
subparse: parsing timestamp '00:00:18,388'
subparse: parsing timestamp '00:00:20,730'
subparse: <parser> segment after seek: time segment start=0:00:00.000000000,
offset=0:00:00.000000000, stop=99:99:99.999999999, rate=1.000000,
applied_rate=1.000000, flags=0x01, time=0:00:00.000000000,
base=0:00:00.000000000, position 0:00:00.000000000, duration 99:99:99.999999999
subparse: <parser> Parsing line '- A quoi ?'
subparse: <parser> set need_segment=1
subparse: <parser> Parsing line '- Au Président Hassan et sa famille.'
subparse: <parser> Parsing line ''                                              
subparse: <parser> Sending text '- A quoi ?
- Au Président Hassan et sa famille.', 0:00:18.388000000 + 0:00:02.342000000

GStreamer-WARNING **:
../../gitsrc/gst/gstpad.c:4042:gst_pad_push_data:<parser:src> Got data flow
before segment event

The "set need_segment=1" print should happen before parsing starts in the chain
function. Could we just send the segment event directly after sending the seek
event ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.