[Bug 740945] directshowdec: Port decoder plugin to 1.x

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740945
  GStreamer | gst-plugins-bad | 1.x

--- Comment #3 from Matthew Bader <matt at hyperlobic.net> 2014-12-02 04:26:11 UTC ---
Thanks for the review :)

> Ideally you would also port them to GstVideoDecoder and GstAudioDecoder ;)

Yes, thought I would get a straightforward port working first and possibly look
at converting later.


> +  gst_dshowaudiodec_parent_class = (GstElementClass *)
> g_type_class_peek_parent (klass);
> 
> G_DEFINE_TYPE() does that for you already

If I remove that line then parent_class is set to null and it crashes...
I looked a while and am not sure what is happening. These classes are being
registered differently than most, with qdata and a base_init.


> That would've been broken before already, but is it guaranteed that
> PushBuffer() creates a copy of the memory if it needs it after the function has
> returned?

PushBuffer copies the data directly into a DirectShow buffer, so I think all is
good here.


> +  query = gst_query_new_allocation(outcaps, TRUE);
> 
> We don't necessarly need a buffer pool here, do we?
> 

I originally didn't have it, but I tried adding one to the video decoder and
noticed lower CPU utilization so I figured I would do it for both. Would a pool
not be more efficient than allocating a fresh buffer each time?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.