[Bug 740987] Fixes to osxaudiosrc and osxaudiosink

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Dec 3 02:44:12 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=740987
  GStreamer | gst-plugins-good | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291921|none                        |reviewed
             status|                            |

--- Comment #14 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-12-03 10:44:06 UTC ---
Review of attachment 291921:
 --> (https://bugzilla.gnome.org/review?bug=740987&attachment=291921)

::: sys/osxaudio/gstosxaudiosink.c
@@ +449,3 @@
   ringbuffer->core_audio->is_src = FALSE;

+  gst_osx_audio_sink_set_volume (osxsink);

Setting volume without having selected the device yet? Shouldn't this move to
select_device()?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list