[Bug 740987] Fixes to osxaudiosrc and osxaudiosink

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740987
  GStreamer | gst-plugins-good | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291928|none                        |needs-work
             status|                            |

--- Comment #19 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-12-03 11:00:24 UTC ---
Review of attachment 291928:
 --> (https://bugzilla.gnome.org/review?bug=740987&attachment=291928)

::: sys/osxaudio/gstosxaudiosrc.c
@@ +301,3 @@
+      /* Caps are fixed, use what we have */
+      ret = gst_pad_get_current_caps (GST_BASE_SINK_PAD (src));
+

Assertion/warning here maybe

::: sys/osxaudio/gstosxcoreaudio.c
@@ +239,3 @@
+
+      ret = gst_caps_new_simple ("audio/x-raw",
+          "format", G_TYPE_STRING, format,

You might want to use a GstAudioInfo here that is filled from the stuff above,
and then just convert that to caps. E.g. you're currently missing the "layout"
field :) Probably the same in the sink specific code?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.