[Bug 740784] subparse: fails to detect UTF-8 encoding

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740784
  GStreamer | gst-plugins-base | git

--- Comment #17 from Athanasios Oikonomou <athoik at gmail.com> 2014-12-03 17:00:45 UTC ---
Tim, the idea of setting detected_encoding was to use gst_convert_to_utf8 since
we have valid UTF-8 data. Usually one srt subtitle is encoded using only one
encoding, so why to validate every buffer? In case gst_convert_to_uf8 fail will
go again on validate (and most probably validate will fail too!).

  /* First try any detected encoding */
  if (self->detected_encoding) {
    ret =
        gst_convert_to_utf8 (str, len, self->detected_encoding, consumed,
&err);

    if (!err)
      return ret;


Reynaldo, You are right! I just tested and both samples work great! 

So please push Reynaldo's patch.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.