[Bug 740945] directshowdec: Port decoder plugin to 1.x

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740945
  GStreamer | gst-plugins-bad | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #292072|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-12-04 17:02:42 UTC ---
Review of attachment 292072:
 --> (https://bugzilla.gnome.org/review?bug=740945&attachment=292072)

Thanks for updating the patch :)

::: sys/dshowdecwrapper/gstdshowaudiodec.cpp
@@ +211,3 @@
     GST_BUFFER_DURATION (out_buf) = duration;
+
+    gst_buffer_set_size(out_buf, gst_buffer_fill(out_buf, 0, pBuffer, size));

Please do this in two separate lines, and also check if gst_buffer_fill() was
successful

::: sys/dshowdecwrapper/gstdshowvideodec.cpp
@@ +789,1 @@
+  caps_out = gst_video_info_to_caps(&video_info);

This code is a bit weird. Maybe don't use GstVideoInfo here and really just do
what the old code was doing. Exactly what the old code was doing.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.