[Bug 741097] oggdemux: Fix seeking before the first frame.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741097
  GStreamer | gst-plugins-base | unspecified

Mathieu Duponchelle <mathieu.duponchelle> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.5.x

--- Comment #2 from Mathieu Duponchelle <mathieu.duponchelle at epitech.eu> 2014-12-05 11:08:05 UTC ---
commit 4e228e0a1f2b01c79378a9d0ba56b58353a5a572
Author: Mathieu Duponchelle <mathieu.duponchelle at opencreed.com>
Date:   Thu Nov 27 05:53:20 2014 +0100

    oggdemux: Fix seeking before the first frame.

    The previous code was setting keytarget to target
    to make sure the keyframe found for each pad was
    indeed before the target.

    Then if target == keytarget, it assumed a keyframe had been
    found, which was not the case if target was before the first frame
    in the file.

    This patch checks that a keyframe was indeed found, and if not
    seeks to 0, without bisecting again.

    Assuming default gst qa assets in $HOME/gst-validate

    seek_before_first_frame.scenario:

    description, seek=true, handles-states=true
    pause, playback-time=0.0
    seek, playback-time=0.0, start=0.0, flags=accurate+flush
    seek, playback-time=0.0, start=0.01, flags=accurate+flush
    seek, playback-time=0.0, start=0.1, flags=accurate+flush

    GST_DEBUG=*theoradec*:2 gst-validate-1.0 playbin \
    uri=file://$HOME/gst-validate/gst-qa-assets/medias/ogg/vorbis_theora.0.ogg
\
    --set-scenario seek_before_first_frame.scenario

    https://bugzilla.gnome.org/show_bug.cgi?id=741097

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.