[Bug 741146] aggregator: deadline based aggregation

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741146
  GStreamer | gst-plugins-bad | git

Olivier Crête <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #292171|none                        |needs-work
             status|                            |

--- Comment #2 from Olivier Crête <olivier.crete at ocrete.ca> 2014-12-05 16:46:55 UTC ---
Review of attachment 292171:
 --> (https://bugzilla.gnome.org/review?bug=741146&attachment=292171)

::: gst-libs/gst/base/gstaggregator.c
@@ +479,3 @@
+{
+  if (buffer && GST_BUFFER_TIMESTAMP_IS_VALID (buffer)) {
+    *start = GST_BUFFER_TIMESTAMP (buffer);

This never happens as this is always called with buffer==NULL?

For the "default case" of subclasses that don't give us times, we should just
disable the deadline system entirely?

@@ +508,3 @@
+/* called with the src STREAM lock */
+static gboolean
+_wait_and_check (GstAggregator * self, GstBuffer * buffer)

Where does the buffer come from? It seems to always be called with NULL?

::: gst-libs/gst/base/gstaggregator.h
@@ +240,3 @@
+  void              (*get_times)      (GstAggregator    *  aggregator,
+                                       GstBuffer        *  buffer,
+                                       GstClockTime     *  start,

My gut feeling is that it should be get_next_time() that returns the start,
because this is called before the buffer is created. And probably allow
returning GST_CLOCK_TIME_NONE to mean "ASAP".

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.