[Bug 741231] New: glfilter: position/texcoord attrib index usage

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741231
  GStreamer | gst-plugins-bad | git

           Summary: glfilter: position/texcoord attrib index usage
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: comicfans44 at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=292278)
 View: https://bugzilla.gnome.org/attachment.cgi?id=292278
 Review: https://bugzilla.gnome.org/review?bug=741231&attachment=292278

misc patch to fix position/texcoord attribute index usage

gstglfilter _bind_buffer (line 1522) call VertexAttribPointer before get the 
attrib location, so 

  _get_attributes (filter);

should be called before

   gl->VertexAttribPointer (filter->draw_attr_position_loc, 3, GL_FLOAT,
       GL_FALSE, 5 * sizeof (GLfloat), (void *) 0);
?
plus, 0 is valid vertex attrib index(-1 is invalid) ,so we should init 
attrib index to -1, and compare with -1 ? if so , this patch fix this.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.