[Bug 741263] videodecoder: implement caps query

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741263
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #292322|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-12-09 08:51:02 UTC ---
Review of attachment 292322:
 --> (https://bugzilla.gnome.org/review?bug=741263&attachment=292322)

Makes sense

::: gst-libs/gst/video/gstvideodecoder.c
@@ +1580,3 @@

+static GstCaps *
+gst_video_decoder_create_other_caps (GstVideoDecoder * decoder, GstPad * pad,

create_other_caps() seems like a weird name. Maybe check
audioencoder/videoencoder for better naming, I remember they have also code
like this (and you might want to refactor that into a utility function if
possible).

@@ +1590,3 @@
+  const GValue *width, *height, *framerate;
+
+  tmpl_caps = gst_pad_get_pad_template_caps (pad);

These have to be unreffed after usage

@@ +1609,3 @@
+        gst_structure_set_value (result_structure, "height", height);
+      if (framerate)
+        gst_structure_set_value (result_structure, "framerate", framerate);

pixel-aspect-ratio too maybe

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.