[Bug 741271] rtph264pay: Buffer leak in H.264 payloader when using SPS/PPS

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741271
  GStreamer | gst-plugins-good | git

--- Comment #6 from Patrick Radizi <patrick.radizi at axis.com> 2014-12-09 13:53:30 UTC ---
I think the patch is ok. The problem seems to be that it changes the timing so
that an 'old' bug is triggered. It only happens sometimes and is dependant on
the debug level used.

I think that the commit 53ffd9e1cab086f334f94597973fdb0fcb175adc is the cause.
Because of this commit two threads are simultaneously using rtph264pay->sps and
rtph264pay->pps. One is the pipeline thread running in
gst_rtp_h264_pay_send_sps_pps the other the thread doing the state change and
calling gst_rtp_h264_pay_clear_sps_pps when going from paused to ready. 

Perhaps I'm missing something but I don't really understand why the return
value of gst_rtp_h264_pay_payload_nal is ignored in
gst_rtp_h264_pay_send_sps_pps, isn't this the cause of this problem?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.