[Bug 740636] v4l2src: framerate is not always set on driver

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Dec 9 15:42:02 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=740636
  GStreamer | gst-plugins-good | 1.4.4

--- Comment #5 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2014-12-09 23:41:59 UTC ---
Created an attachment (id=292414)
 View: https://bugzilla.gnome.org/attachment.cgi?id=292414
 Review: https://bugzilla.gnome.org/review?bug=740636&attachment=292414

[PATCH] v4l2object: Always set format


Right now we try to be clever by detecting if device format have
changed or not, and skip setting format in this case. This is valid
behaviour with V4L2, but it's also very error prone. The rational
for not setting these all the time is for speed, though I can't
measure any noticeable gain on any HW I own. Also, until recently,
we where doing get/set on the format for each format we where
probing, making it near to impossible that the format would match.
This also fixes bug where we where skipping frame-rate setting if
format didn't change.

https://bugzilla.gnome.org/show_bug.cgi?id=740636
---
 sys/v4l2/gstv4l2object.c | 70 +-----------------------------------------------
 1 file changed, 1 insertion(+), 69 deletions(-)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list