[Bug 611689] [NEW PLUGIN] crossfeed plugin

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=611689
  GStreamer | gst-plugins-bad | git

Stefan Sauer (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #284336|none                        |reviewed
             status|                            |

--- Comment #8 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2014-12-10 20:04:23 UTC ---
Review of attachment 284336:
 --> (https://bugzilla.gnome.org/review?bug=611689&attachment=284336)

::: ext/bs2b/gstbs2b.c
@@ +22,3 @@
+ * SECTION:element-bs2b
+ *
+ * Improve headphone listening of stereo audio records using the bs2b library.

Could you expand this a little and tell how it improves the audio?

@@ +68,3 @@
+{
+  PROP_0,
+  PROP_FCUT,

PROP_FCUT = 1,
and remove the PROP_0

@@ +267,3 @@
+    case GST_EVENT_SEGMENT:
+      GST_BS2B_DP_LOCK (element);
+      bs2b_clear (element->bs2bdp);

what is this doing? Maybe do this when the input-buffer has the DISCONT flag
set?

@@ +343,3 @@
+      bs2b_clear (element->bs2bdp);
+      GST_BS2B_DP_UNLOCK (element);
+      g_object_notify_by_pspec (object, properties[PROP_PRESET]);

you don't need to do this.

@@ +356,3 @@
+        case PRESET_DEFAULT:
+          GST_BS2B_DP_LOCK (element);
+          bs2b_set_level (element->bs2bdp, BS2B_DEFAULT_CLEVEL);

Could you use the values in the enum to avoid the switch case here? Like drop
PRESET_{DEFAULT, CMOY, ...} and use BS2B_{DEFAULT,CMOY,..}_CLEVEL in the enum
above.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.