[Bug 740987] Fixes to osxaudiosrc and osxaudiosink

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Dec 12 02:17:10 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=740987
  GStreamer | gst-plugins-good | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #292598|none                        |needs-work
             status|                            |

--- Comment #35 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-12-12 10:17:07 UTC ---
Review of attachment 292598:
 --> (https://bugzilla.gnome.org/review?bug=740987&attachment=292598)

::: sys/osxaudio/gstosxaudiosink.c
@@ +367,3 @@
+      /* Caps are fixed, use what we have */
+      ret = gst_pad_get_current_caps (GST_BASE_SINK_PAD (sink));
+      g_return_val_if_fail (ret, NULL);

This would forget to unlock the mutex

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list