[Bug 740987] Fixes to osxaudiosrc and osxaudiosink

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740987
  GStreamer | gst-plugins-good | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #292600|none                        |needs-work
             status|                            |

--- Comment #36 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-12-12 10:20:35 UTC ---
Review of attachment 292600:
 --> (https://bugzilla.gnome.org/review?bug=740987&attachment=292600)

::: sys/osxaudio/gstosxaudiosrc.c
@@ +301,3 @@
+      /* Caps are fixed, use what we have */
+      ret = gst_pad_get_current_caps (GST_BASE_SINK_PAD (src));
+      g_return_val_if_fail (ret, NULL);

Forget to unlock

@@ +316,3 @@
+  if (filter) {
+    GstCaps *tmp;
+    tmp = gst_caps_intersect_full (ret, filter, GST_CAPS_INTERSECT_FIRST);

We usually have the filter first here as we ideally output what the other
elements want

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.