[Bug 741407] Deinterlace: in query_caps return only supported formats if filter is interlaced

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Dec 14 03:03:42 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=741407
  GStreamer | gst-plugins-good | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #292555|none                        |accepted-commit_now
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-12-14 11:03:38 UTC ---
Review of attachment 292555:
 --> (https://bugzilla.gnome.org/review?bug=741407&attachment=292555)

Looks good except for one little thing. Please push after fixing that :)

::: gst/deinterlace/gstdeinterlace.c
@@ +2151,3 @@
+
+    filter_interlaced = TRUE;
+    for (i = 0; i < gst_caps_get_size (filter); i++) {

Store gst_caps_get_size() in a variable instead of getting it again on every
iteration :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list