[Bug 741280] matroskademux: Send GAP events for non sparse streams

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741280
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #292343|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-12-14 11:11:51 UTC ---
Review of attachment 292343:
 --> (https://bugzilla.gnome.org/review?bug=741280&attachment=292343)

::: gst/matroska/matroska-demux.c
@@ +2474,3 @@
+      tolerance = GST_SECOND / 2;
+    } else {
+      tolerance = GST_SECOND * 5;

5 seconds is quite a lot, and that can easily be enough to fill up queues
downstream and stall the pipeline.

I think other demuxers are also using 0.5s as a tolerance for all streams. But
in any case a smaller value than 5s would probably be good. Did you notice
problems with 0.5s? What about 2s?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.