[Bug 740752] add retransmission support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740752
  GStreamer | gst-rtsp-server | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291884|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-12-14 11:32:49 UTC ---
Review of attachment 291884:
 --> (https://bugzilla.gnome.org/review?bug=740752&attachment=291884)

Looks good, please push after the following few changes :)

::: gst/rtsp-server/rtsp-media.c
@@ +1272,3 @@
+    guint pt = gst_rtsp_stream_get_pt (stream);
+
+    ret = g_list_append (ret, GUINT_TO_POINTER (pt));

prepend here, and then reverse the list in the end. That's faster

@@ +1412,3 @@
+
+    if (rtx_pt == 0) {
+      /* FIXME: ran out of space of dynamic payload types */

GST_WARNING_OBJECT() maybe

::: gst/rtsp-server/rtsp-stream.c
@@ +1369,3 @@
+  if (stream->priv->rtxsend) {
+    guint pt = gst_rtsp_stream_get_pt (stream);
+    gchar *pt_s = g_strdup_printf ("%d", pt);

This string is leaked

@@ +1753,3 @@
+
+  pt = gst_rtsp_stream_get_pt (stream);
+  pt_s = g_strdup_printf ("%u", pt);

And this

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.