[Bug 740683] rtspsrc: add retransmission handling for rtp

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740683
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291886|none                        |reviewed
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-12-14 11:36:45 UTC ---
Review of attachment 291886:
 --> (https://bugzilla.gnome.org/review?bug=740683&attachment=291886)

Looks good, just a question. Feel free to push it if that all makes sense :)

::: gst/rtsp/gstrtspsrc.c
@@ +3140,3 @@
+  GST_INFO_OBJECT (src, "creating retransmision receiver for session %u "
+      "with map %" GST_PTR_FORMAT, sessid, stream->rtx_pt_map);
+  bin = gst_bin_new (NULL);

Why a bin with a single element instead of just having that element directly?

@@ +3174,3 @@
+  if (g_signal_handler_find (src->manager, G_SIGNAL_MATCH_ID, signal_id, 0,
+          NULL, NULL, NULL) != 0)
+    return;

Maybe add a GST_DEBUG_OBJECT() here just in case

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.