[Bug 741146] aggregator: deadline based aggregation

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741146
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #292280|none                        |reviewed
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-12-14 11:47:21 UTC ---
Review of attachment 292280:
 --> (https://bugzilla.gnome.org/review?bug=741146&attachment=292280)

Is there anything needed in audiomixer to handle this properly, other than
implementing get_next_time()?


Looks mostly good to me, feel free to just push after these changes

::: gst-libs/gst/base/gstaggregator.c
@@ +167,3 @@
+  } G_STMT_END
+
+#define SRC_STREAM_BROADCAST(self) {                                       \

Use G_STMT_START/END here

@@ +174,3 @@
+
+#define KICK_SRC_THREAD(self) \
+  do { \

And here

@@ +518,3 @@
+        GST_TIME_ARGS (start));
+
+    time = GST_ELEMENT_CAST (self)->base_time + start;

Accessing the base time might need the object lock

@@ +522,3 @@
+    if (GST_CLOCK_TIME_IS_VALID (latency_max)) {
+      time += latency_max;
+    } else if (GST_CLOCK_TIME_IS_VALID (latency_min)) {

The min latency should always be valid IIRC. It should never be
GST_CLOCK_TIME_NONE, but instead the "default" value is 0

@@ +538,3 @@
+
+    self->priv->aggregate_id =
+        gst_clock_new_single_shot_id (GST_ELEMENT_CLOCK (self), time);

Accessing the clock needs the object lock

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.