[Bug 734424] videorate produces bogus output when framerate=0/1

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=734424
  GStreamer | gst-plugins-base | 1.4.0

--- Comment #25 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-12-14 19:41:08 UTC ---
Can we get tests for all the possible cases?


(In reply to comment #19)
> @@ +933,3 @@
> +  g_object_get (GST_BASE_TRANSFORM_SRC_PAD (videorate), "caps", &srcpadcaps,
> +      NULL);
> +  gst_video_guess_framerate (GST_BUFFER_PTS (buffer), &fps_n, &fps_d);
> 
> Basically I take the timestamp of the second buffer to compute the framerate
> should be buffer->pts - prev->ts actually here (DONE), and indeed I do not know
> if it will be the average and I make the assumption that timestamps from
> upstream are correct.

That assumption was wrong and only worked for the case if the first buffer has
a timestamp of 0 :) Thanks for fixing.

> @@ +958,3 @@
> +
> +  gst_pad_push_event (GST_BASE_TRANSFORM_SRC_PAD (videorate),
> +      gst_event_new_caps (tmpcaps));
> 
> And What do I do with the current buffers? IIUC that implies I need to wait for
> the next buffer to be chained.

Yes. Maybe basetransform needs new API for your use case here?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.