[Bug 741359] check.h distributed unnecessarily

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741359
  GStreamer | gstreamer (core) | git

--- Comment #9 from Sebastian Rasmussen <sebras at hotmail.com> 2014-12-14 20:57:49 UTC ---
libs/gst/check/check.h. This is really difficult to explain, but let me try:

So we are talking about these files:
libs/gst/check/libcheck/check.h.in --generates-->
libs/gst/check/libcheck/check.h
libs/gst/check/libcheck/check.h --included-by-> libs/gst/check/libcheck/*.[ch]
libs/gst/check/libcheck/check.h --copied-to--> libs/gst/check/internal-check.h
libs/gst/check/internal-check.h --included-by--> libs/gst/check/gstcheck.h
libs/gst/check/gstcheck.h --included-by--> libs/gst/check/check.h
libs/gst/check/check.h --included-by-> all unit tests

By using autotools I can change this to:
libs/gst/check/libcheck/check.h.in --generates--> libs/gst/check/check.h
libs/gst/check/libcheck/check.h --included-by-> libs/gst/check/libcheck/*.[ch]
libs/gst/check/check.h --included-by--> libs/gst/check/gstcheck.h
libs/gst/check/gstcheck.h --included-by--> libs/gst/check/check.h (This is the
problem)
libs/gst/check/check.h --included-by-> all unit tests (This is also the
problem)

But since check.h can not be used to contain both the generated contents
and the manually created check.h I opted to keep the file name
internal-check.h:
libs/gst/check/libcheck/check.h.in --generates-->
libs/gst/check/internal-check.h
libs/gst/check/internal-check.h --included-by-> libs/gst/check/libcheck/*.[ch]
(Diverges more from upstream libcheck)
libs/gst/check/internal-check.h --included-by--> libs/gst/check/gstcheck.h
libs/gst/check/gstcheck.h --included-by--> libs/gst/check/check.h
libs/gst/check/check.h --included-by-> all unit tests

In this last example we refrain from copying internal-check.h to check.h, but
at the cost of diverging from upstream a bit more.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.