[Bug 741501] videopool: should update video alignment after change it

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Dec 14 18:13:38 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=741501
  GStreamer | gst-plugins-base | 1.4.1

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2014-12-15 02:13:35 UTC ---
Review of attachment 292726:
 --> (https://bugzilla.gnome.org/review?bug=741501&attachment=292726)

It seem rather harmless, but it is slightly against
gst_buffer_pool_set_config() documentation that says that if your pool changes
a parameter in the config it should return false. It's not really changing the
alignment, this patch in fact replace the user selected alignment with the
applied alignment. Would it be possible to explain in what situation it is
required to read back the alignment from the buffer pool configuration ? This
is important that we understand and document this behaviour. If we decide that
the config shall be update with applied alignment, this patch should come with
a V4l2 buffer pool update to be consitent (along with any pool I may have
forgotten).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list