[Bug 741420] video pools: should update size in configuration after applying alignement

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Dec 16 02:55:55 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=741420
  GStreamer | gst-plugins-base | 1.4.1

--- Comment #13 from Wim Taymans <wim.taymans at gmail.com> 2014-12-16 10:55:48 UTC ---
(In reply to comment #9)
> I'm starting to think the right fix here would be to relax the check, or
> memorise allocation size upon first allocation. As stated by Arnaud in bug
> #735386, there might be cases where you don't really know what size is going to
> be the buffer before you actually have allocated it. This could make sense,
> since the original intention is to validate that the size is back to normal
> before it's being stored back into the pool.

I think the size check could be removed. I think you should just restore the
size of the buffer to it's original expected size (that you configured in
set_config) in the reset_buffer function (or release_buffer). You should, in
fact, not only restore the size of the buffer but also any of the metadata on
the buffer (in case the metadata is not marked readonly) and possibly the
prefix etc.

It would be nice if we could mark all buffer metadata as readonly somehow..

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list