[Bug 741263] videodecoder: implement caps query

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741263
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #292919|none                        |needs-work
             status|                            |

--- Comment #22 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-12-17 19:55:35 UTC ---
Review of attachment 292919:
 --> (https://bugzilla.gnome.org/review?bug=741263&attachment=292919)

::: gst-libs/gst/video/gstvideodecoder.c
@@ +1582,3 @@
+ * gst_video_decoder_proxy_getcaps:
+ * @decoder: a #GstVideoDecoder
+ * @caps: initial caps

@caps: (allow-none): initial caps

@@ +1583,3 @@
+ * @decoder: a #GstVideoDecoder
+ * @caps: initial caps
+ * @filter: filter caps

Also (allow-none)? Can be NULL, right?

@@ +1589,3 @@
+ * elements.
+ *
+ * Returns: a #GstCaps owned by caller

Returns: (transfer full): a #GstCaps owned by the caller

@@ +1613,3 @@
+    caps = klass->getcaps (decoder, filter);
+  else
+    caps = gst_video_decoder_proxy_getcaps (decoder, NULL, filter);

I think here is a problem now with acceptcaps.

klass->getcaps() can return a subset of the template caps, e.g. if the actual
hardware currently available can do less than the element could do in general.
In that case you would here return stricter caps, but acceptcaps would accept
less strict caps (it only checks subset against template, and then intersection
against gst_video_decoder_proxy_getcaps(), right?)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.