[Bug 735653] mpegts: return early if packetizing short section

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Dec 19 05:03:57 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=735653
  GStreamer | gst-plugins-bad | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #284793|none                        |reviewed
             status|                            |

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-12-19 13:03:52 UTC ---
(From update of attachment 284793)
>   if (!section->short_section)
>     *data |= 0x80;
> 
>+  /* short sections do not contain more fields */
>+  if (section->short_section)
>+    return;
>+

Looks good to me, but how about moving that if/return up before the previous if
(!section->short_section) check, and getting rid of that then?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list