[Bug 733864] v4l2videodec: Implement EOS handling through V4L2_DEC_CMD_STOP

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Dec 19 16:45:19 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=733864
  GStreamer | gst-plugins-good | git

Nicolas Dufresne (stormer) <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #293100|none                        |reviewed
             status|                            |

--- Comment #8 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2014-12-20 00:45:17 UTC ---
Review of attachment 293100:
 --> (https://bugzilla.gnome.org/review?bug=733864&attachment=293100)

::: sys/v4l2/v4l2_calls.c
@@ +1150,3 @@
+      (_("Failed to send encoder command %u with flags %u for '%s'."),
+      cmd, flags, v4l2object->videodev), GST_ERROR_SYSTEM);
+  return FALSE;

ENOTTY should not be fatal. We just need to know and fallback. To be honest, I
would not add a helper for these

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list