[Bug 733864] v4l2videodec: Implement EOS handling through V4L2_DEC_CMD_STOP

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Dec 19 17:33:13 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=733864
  GStreamer | gst-plugins-good | git

--- Comment #13 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2014-12-20 01:33:10 UTC ---
(In reply to comment #1)
> Note the since 3.18, it's no longer possible to use the old method since when
> we set the payload (bytesused) to 0, the videobuf2 framework now set bytesused
> to length.

Small update on this one. This was not a choice but a regression. Patches as
been submitted:

Framework flag
https://patchwork.kernel.org/patch/5500311/
MFC fix
https://patchwork.kernel.org/patch/5500321/
CODA fix
https://patchwork.kernel.org/patch/5518741/

It is still recommended to move forward with CMD_STOP. I'd like to clarify that
I want this to be backward compatibly at least for 1 or 2 more version of
GStreamer.

For more context, both of these driver signal currently signal the EOS through
an event after sending the last buffer. Though this method is slightly
controversial, since the EOS is meant to signal the the OUTPUT queue of a
decoder (M2M or not) has been processed. Sending EOS only after the last
CAPTURE buffer has been dequeued is slightly off the spec here. This is to be
addressed first on linux-media ML.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list