[Bug 741893] New: inputselector: should get active sink pad again before decide if need forward event

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741893
  GStreamer | gstreamer (core) | git

           Summary: inputselector: should get active sink pad again before
                    decide if need forward event
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: kevinbing.song at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


I found below patch remove one line one latest code. But the line is critical
and can't removed. We should keep get the active sink pad in lock as change
active sink pad also work in lock. Attached patch to fix the issue.

commit 82850026934b3c89465ac8d02e671d6268ba1586
Author: Stefan Sauer <ensonic at users.sf.net>
Date:   Fri Oct 3 14:01:59 2014 +0200

    input-selector: small code cleanups

    Rename TIMESTAMP -> PTS. Move a var down to the scope where it is used. Use
    g_queue_free_full().

@@ -470,7 +465,6 @@ gst_selector_pad_event (GstPad * pad, GstObject * parent,
GstEvent * event)
     gst_object_unref (prev_active_sinkpad);

   GST_INPUT_SELECTOR_LOCK (sel);
-  active_sinkpad = gst_input_selector_activate_sinkpad (sel, pad);

   /* only forward if we are dealing with the active sinkpad */
   forward = (pad == active_sinkpad);

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.