[Bug 740949] inputselector: sticky events haven't send out when active track reach EOS.

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Dec 23 04:16:31 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=740949
  GStreamer | gstreamer (core) | 1.2.3

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #293223|none                        |needs-work
             status|                            |

--- Comment #27 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-12-23 12:16:25 UTC ---
Review of attachment 293223:
 --> (https://bugzilla.gnome.org/review?bug=740949&attachment=293223)

::: plugins/elements/gstinputselector.c
@@ +1179,3 @@
+      res = GST_FLOW_OK;
+    else
+      res = GST_FLOW_NOT_LINKED;

Should be GST_FLOW_EOS in both cases

::: plugins/elements/gstinputselector.h
@@ +79,3 @@
   gboolean blocked;
+  gboolean eos;
+  gboolean eos_blocked;

Can't you use a single variable for both? Just eos?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list