[Bug 719849] [PLUGIN-MOVE] move mpg123 to -ugly

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=719849
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #266869|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-02-04 11:45:44 UTC ---
Review of attachment 266869:
 --> (https://bugzilla.gnome.org/review?bug=719849&attachment=266869)

::: ext/mpg123/gstmpg123audiodec.c
@@ +339,3 @@
       } else {
+        GST_ELEMENT_ERROR (mpg123_decoder, RESOURCE, READ, (NULL),
+            ("gst_memory_map() failed"));

Please use GST_AUDIO_DECODER_ERROR(), it will only error out completely after a
few consecutive errors then

@@ +423,3 @@
           char const *errmsg = mpg123_plain_strerror (errcode);
+          GST_ELEMENT_ERROR (mpg123_decoder, STREAM, DECODE, (NULL),
+              ("mpg123 decoding error: %s", errmsg));

And here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.