[Bug 722767] element: add function to sync element state with target state of the parent

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722767
  GStreamer | gstreamer (core) | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #267402|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-02-04 12:29:34 UTC ---
Review of attachment 267402:
 --> (https://bugzilla.gnome.org/review?bug=722767&attachment=267402)

::: gst/gstelement.c
@@ +2016,3 @@
+ * Returns: TRUE, if the element's state could be synced to the parent's
state.
+ *
+ * MT safe.

Please add a "Since: 1.4" line here

@@ +2044,3 @@
+  gst_object_unref (parent);
+
+  ret = gst_element_set_state (element, target);

Shouldn't we sync the state with the parent's state, but at the same time set
the target to the parent's target state instead? Would be another option... but
I guess what you do here right now makes most sense actually.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.