[Bug 721764] souphttpsrc: Add ability to do HTTP session logging

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721764
  GStreamer | gst-plugins-good | git

--- Comment #28 from Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> 2014-02-07 14:56:19 UTC ---
(In reply to comment #26)
> Review of attachment 266270 [details]:
> 
> ::: ext/soup/gstsouphttpsrc.h
> @@ +24,2 @@
>  #include <libsoup/soup.h>
> +#include "gstsouputils.h"
> 
> No need for the header here, only needed in the .c file

Leftover from a previous incarnation. Thanks for pointing it
out.

> ::: ext/soup/gstsouputils.c
> @@ +50,3 @@
> +       * log level to SoupLoggerLogLevel and it should be added
> +       * as a case */
> +      c = level + '0';
> 
> This will break in interesting ways for too high levels. Maybe add an assertion
> here if level is too large, or use multiple characters. Or get the
> SoupLoggerLogLevel nick from the GEnum and just always use that

There's already an if (G_UNLIKELY (level > 9)) return '?' on top
of the switch to avoid that case. You might have missed it.

Thanks for your review! Updated patch attached.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.