[Bug 724131] colorbalance: add colorbalance meta API

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=724131
  GStreamer | gst-plugins-base | git

--- Comment #4 from Matthieu Bouron <matthieu.bouron at collabora.com> 2014-02-11 18:49:06 UTC ---
(In reply to comment #1)
> I'm not sure this is the right design, or at least it does not seem coherent
> with GstColorBalance interface. ColorBalance, suggest that an element can have
> an arbitrary amount of Channels that can be controlled. Base on that, if an
> element wants to offload it's work to downstream it should negotiate the
> required channels. This negotiation could be made dynamic, in a way that if
> downstream support only hue, and only hue is set to non default, then we would
> still do passthrough. But at soon as "unsupported" brightness gets set, then it
> will use software path (if allocation permits it, e.g. system memory and known
> color format).

>From what I understand, currently, playsink only uses one videobalance element
(the more upstream one).

So I agree with you that upstream videobalance elements should look if
downstream supports the colorbalance API (per channel) and enter passthrough
mode depending on what downstream supports.

IMHO, a kind of API like the one proposed here is still needed because only one
element is controlled by playsink and this element will need to tell the
downstream videobalance element to modify the videobalance properties.

The allocation query might be used here to see if downstream supports the
colorbalance API and which channels are supported.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.