[Bug 724393] gst-plugins-base: allow specifying an anchor certificate file in gstrtspconnection

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=724393
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #269158|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-02-16 09:01:19 UTC ---
Review of attachment 269158:
 --> (https://bugzilla.gnome.org/review?bug=724393&attachment=269158)

Seems like a good idea, just some questions.

::: gst-libs/gst/rtsp/gstrtspconnection.c
@@ +230,3 @@
+
+    if (error)
+      goto verify_error;

Shouldn't this use the tls-validation-flags property here to ignore some errors
but not others, like what happens in rtspsrc?

@@ +580,3 @@
+ * Sets the anchor certificate authorities database file. This
+ * certificate database will be used after a server certificate can't be
+ * verified with the default certificate database.

Does this require a single file with all certificates or can it also be a
directory like /etc/ssl/certs ?

@@ +2251,3 @@
  *
  * Close and free @conn.
+ *

Please get rid of all these useless whitespace changes :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.