[Bug 724509] playbin with appsink audio-sink doesn't handle caps well
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Tue Feb 18 02:29:28 PST 2014
https://bugzilla.gnome.org/show_bug.cgi?id=724509
GStreamer | gst-plugins-base | 1.2.2
Tim-Philipp Müller <t.i.m> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
Target Milestone|HEAD |1.3.1
--- Comment #5 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-02-18 10:49:41 UTC ---
Thanks for the patch! Would be great if you could supply the patch in 'git
format-patch' format next time, that makes applying it easier for us.
I've also added a secondary sanity check/fix in audioconvert:
commit 6c6619a66922bac0c343c4a5623d5bdb322f0e92
Author: Tim-Philipp Müller <tim at centricular.com>
Date: Tue Feb 18 10:42:04 2014 +0000
audioconvert: never do mixing for 1->1 channel conversions
MONO and NONE position are the same, for example, but in
general there isn't much to do here for such a conversion.
Fixes problem in audioconvert, which would end up using
a mixmatrix when converting between different mono format
because it thinks MONO positioning is different from
unpositioned channels, which is not the case in this
special case. The mixmatrix would end up being 0.0 so
audioconvert would convert to silence samples.
https://bugzilla.gnome.org/show_bug.cgi?id=724509
commit 5496d09eb42fa63d725f0a01ac6c7584126bc5da
Author: Rafał Mużyło <galtgendo at o2.pl>
Date: Tue Feb 18 10:32:46 2014 +0000
audio: map channels=1,channel-mask=0 to MONO instead of NONE
Fixes problem in audioconvert, which would end up using
a mixmatrix when converting between different mono format
because it thinks MONO positioning is different from
unpositioned channels, which is not the case in this
special case. The mixmatrix would end up being 0.0 so
audioconvert would convert to silence samples.
https://bugzilla.gnome.org/show_bug.cgi?id=724509
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list