[Bug 724571] In collectpads, the collected function is sometimes called incorrectly.

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Feb 18 17:35:42 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=724571
  GStreamer | gstreamer (core) | git

Mathieu Duponchelle <mathieu.duponchelle> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #269454|0                           |1
        is obsolete|                            |

--- Comment #1 from Mathieu Duponchelle <mathieu.duponchelle at epitech.eu> 2014-02-19 01:56:01 UTC ---
Created an attachment (id=269649)
 View: https://bugzilla.gnome.org/attachment.cgi?id=269649
 Review: https://bugzilla.gnome.org/review?bug=724571&attachment=269649

This patch corrects the observed bug.

This patch corrects the observed bug. The previously attached test case
"succeeds" in that instead of failing it hangs on the thread joining as
logically gst_pad_push now blocks instead of running collected.

There still are theoretically races with that patch, but it makes the situation
better, Sebastian's rework of collectpads should hopefully make the situation
better and the code clearer, I'm available to discuss all this on IRC.

I'll attach an updated test case after that.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list