[Bug 724638] aacparse : Missing resilience when no audio frame is found

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Feb 19 06:43:17 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=724638
  GStreamer | gst-plugins-good | git

--- Comment #6 from Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> 2014-02-19 15:03:40 UTC ---
Hi Thiago, thanks for your review. If I proceed that way
I will have to leave the > 2 check in place just for checking
for > 6 bellow the main if block. Which doesn't make a lot of sense
considering the function should do nothing but return FALSE if
those conditions aren't met. I actually considered dropping the
whole main if and have these few checks on top but as that required
to reindent the whole function for no procedural reason I opted
out of it. Can you take a look again and comment please?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


More information about the gstreamer-bugs mailing list